[PATCH] D63309: [llvm-objcopy][MachO] Rebuild the symbol/string table in the writer

Alexander Shaposhnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 19 19:15:42 PDT 2019


alexshap added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/MachO/Object.h:227
+
+  StringTableBuilder StrTableBuilder{StringTableBuilder::MachO};
 };
----------------
I'm wondering if MachOWriter would be a better place for StrTableBuilder ?
MachOWriter::constructStringTable, MachOWriter::writeStringTable, MachOWriter::totalSize, MachOWriter::writeSymbolTable are the only users of this object, aren't they ? 



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63309/new/

https://reviews.llvm.org/D63309





More information about the llvm-commits mailing list