[PATCH] D63583: [Support] Add fs::getUmask() function and change fs::setPermissions

[Alex Brachet via Phabricator via llvm-commits]

abrachet marked an inline comment as done.
abrachet added a comment.

This change is not 100% necessary it doesn't need to be in lib/Support, but I am planning on using it for D62718 <https://reviews.llvm.org/D62718>. I figured I would test the waters on this one. Also, fs::getUmask() isn't necessary to have, I think that the change to fs::setPermissions would be enough, but I figured I would add it and remove later than the other way around.



================
Comment at: llvm/lib/Support/Windows/Path.inc:741
+
+std::error_code setPermissions(const Twine &Path, perms Permissions, bool /*RespectUmask*/) {
   SmallVector<wchar_t, 128> PathUTF16;
----------------
I don't know if unnamed parameters are allowed per the style guide, it isn't used by the Windows version of this function, this was the thinking behind this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63583/new/

https://reviews.llvm.org/D63583