[PATCH] D62423: [globalisel][legalizer] Attempt to write down the minimal legalization rules

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 19 14:18:58 PDT 2019


qcolombet added a comment.

Hi @Petar.Avramovic ,

I second Daniel's comment, this is RegBankSelect's job to do this choice and the Legalizer shouldn't need to know about f64 vs. s64.

>   This way we duplicate some of the code from Legalizer and legalize/combine some instructions manually.

The way it was thought was that RegBankSelect should be able to call any Legalizer helper or whatever way you want to share the code between the legalizer and RegBankSelect.

Cheers,
-Quentin


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62423/new/

https://reviews.llvm.org/D62423





More information about the llvm-commits mailing list