[llvm] r363780 - Make TargetParserTest.ARMExtensionFeatures not run out of memory on 32-bit (PR42316)

[Hans Wennborg via llvm-commits]

Seems fine to me, but Sjoerd also said on the bug that he's rewriting
the test to be more sane.

On Wed, Jun 19, 2019 at 8:04 PM Jordan Rupprecht via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
>
> I saw this test timeout internally (not sure how, it doesn't seem _that_ slow), so I committed r363851 as a different fix which I think should also suffice for the memory growth issue -- but I don't have a 32-bit machine to verify on, so PTAL.
>
> On Wed, Jun 19, 2019 at 2:43 AM Hans Wennborg via llvm-commits <llvm-commits at lists.llvm.org> wrote:
>>
>> Author: hans
>> Date: Wed Jun 19 02:46:37 2019
>> New Revision: 363780
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=363780&view=rev
>> Log:
>> Make TargetParserTest.ARMExtensionFeatures not run out of memory on 32-bit (PR42316)
>>
>> The test still probably shouldn't run this loop 17 million times, but at
>> least now it won't run out of memory.
>>
>> Modified:
>>     llvm/trunk/unittests/Support/TargetParserTest.cpp
>>
>> Modified: llvm/trunk/unittests/Support/TargetParserTest.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/Support/TargetParserTest.cpp?rev=363780&r1=363779&r2=363780&view=diff
>> ==============================================================================
>> --- llvm/trunk/unittests/Support/TargetParserTest.cpp (original)
>> +++ llvm/trunk/unittests/Support/TargetParserTest.cpp Wed Jun 19 02:46:37 2019
>> @@ -569,15 +569,16 @@ TEST(TargetParserTest, ARMFPURestriction
>>  }
>>
>>  TEST(TargetParserTest, ARMExtensionFeatures) {
>> -  std::vector<StringRef> Features;
>>    unsigned Extensions = ARM::AEK_CRC | ARM::AEK_CRYPTO | ARM::AEK_DSP |
>>                          ARM::AEK_HWDIVARM | ARM::AEK_HWDIVTHUMB | ARM::AEK_MP |
>>                          ARM::AEK_SEC | ARM::AEK_VIRT | ARM::AEK_RAS | ARM::AEK_FP16 |
>>                          ARM::AEK_FP16FML | ARM::AEK_FP_DP;
>>
>> -  for (unsigned i = 0; i <= Extensions; i++)
>> +  for (unsigned i = 0; i <= Extensions; i++) {
>> +    std::vector<StringRef> Features;
>>      EXPECT_TRUE(i == 0 ? !ARM::getExtensionFeatures(i, Features)
>>                         : ARM::getExtensionFeatures(i, Features));
>> +  }
>>  }
>>
>>  TEST(TargetParserTest, ARMFPUFeatures) {
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits