[PATCH] D62685: [RISCV] Add pseudo instruction for calls with explicit register

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 19 08:48:19 PDT 2019


asb added a comment.

In D62685#1550130 <https://reviews.llvm.org/D62685#1550130>, @lewis-revill wrote:

> Should the error change at all? We'll still get 'error: operand must be a bare symbol name' for `call foo, bar`. I guess this patch doesn't put us in a greate situation now that `parseCallSymbol` can return `NoMatch` even though //technically// we parsed a call symbol...


The error message could certainly be improved, but I don't mind that it's not perfect for those sort of edge case inputs - just that we check an error is produced and we don't get some weird internal assert or anything.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62685/new/

https://reviews.llvm.org/D62685





More information about the llvm-commits mailing list