[llvm] r363821 - Specify log level for CMake messages (less stderr)

Stefan Granitz via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 19 08:25:32 PDT 2019


Author: stefan.graenitz
Date: Wed Jun 19 08:25:32 2019
New Revision: 363821

URL: http://llvm.org/viewvc/llvm-project?rev=363821&view=rev
Log:
Specify log level for CMake messages (less stderr)

Summary:
Specify message levels in CMake. Prefer STATUS (stdout).

As the default message mode (i.e. level) is NOTICE in CMake, more then necessary messages get printed to stderr. Some tools,  noticably ccmake treat this as an error and require additional confirmation and re-running CMake's configuration step.

This commit specifies a mode (either STATUS or WARNING or FATAL_ERROR)  instead of the default.

* I used `csearch -f 'llvm-project/.+(CMakeLists\.txt|cmake)' -l 'message\("'` to find all locations.
* Reviewers were chosen by the most common authors of specific files. If there are more suitable reviewers for these CMake changes, please let me know.

Patch by: Christoph Siedentop

Reviewers: zturner, beanz, xiaobai, kbobyrev, lebedev.ri, sgraenitz

Reviewed By: sgraenitz

Subscribers: mgorny, lebedev.ri, #sanitizers, lldb-commits, llvm-commits

Tags: #sanitizers, #lldb, #llvm

Differential Revision: https://reviews.llvm.org/D63370

Modified:
    llvm/trunk/cmake/modules/LLVMInstallSymlink.cmake

Modified: llvm/trunk/cmake/modules/LLVMInstallSymlink.cmake
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/LLVMInstallSymlink.cmake?rev=363821&r1=363820&r2=363821&view=diff
==============================================================================
--- llvm/trunk/cmake/modules/LLVMInstallSymlink.cmake (original)
+++ llvm/trunk/cmake/modules/LLVMInstallSymlink.cmake Wed Jun 19 08:25:32 2019
@@ -12,7 +12,7 @@ function(install_symlink name target out
 
   set(bindir "${DESTDIR}${CMAKE_INSTALL_PREFIX}/${outdir}/")
 
-  message("Creating ${name}")
+  message(STATUS "Creating ${name}")
 
   execute_process(
     COMMAND "${CMAKE_COMMAND}" -E ${LINK_OR_COPY} "${target}" "${name}"




More information about the llvm-commits mailing list