[PATCH] D63141: [DAGCombine] GetNegatedExpression - add FMA\FMAD support

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 19 07:38:25 PDT 2019


RKSimon added a comment.

In D63141#1548152 <https://reviews.llvm.org/D63141#1548152>, @arsenm wrote:

> LGTM. Does everything still pass if you delete the FMA/FMAD case in AMDGPUTargetLowering::performFNegCombine?


Thanks for pointing that out - it made me realise there's an issue in that we're not checking for UnsafeMath/hasNoSignedZeros like we do for FADD.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63141/new/

https://reviews.llvm.org/D63141





More information about the llvm-commits mailing list