[PATCH] D63543: [MCA][Bottleneck Analysis] Teach how to compute a critical sequence of instructions based on the simulation.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

A few minors



================
Comment at: test/tools/llvm-mca/X86/SkylakeClient/bottleneck-analysis.s:59
+# CHECK-NEXT:  |      2.    vmulps	-24(%rsp), %xmm7, %xmm8
+# CHECK-NEXT:  +----> 3.    vpermilps	$170, %xmm0, %xmm6                ## REGISTER dependency:  %xmm0
+# CHECK-NEXT:  |      4.    vpermilps	$85, %xmm0, %xmm5
----------------
(very pedantic) Fix the Dependency Information column indentation to be consistent? 


================
Comment at: tools/llvm-mca/Views/BottleneckAnalysis.cpp:185
+
+  do {
+    for (unsigned IID : RootSet) {
----------------
Comments describing whats going on?


================
Comment at: tools/llvm-mca/Views/BottleneckAnalysis.cpp:210
+    SmallVectorImpl<const DependencyEdge *> &Seq) const {
+  const auto It = std::max_element(
+      Nodes.begin(), Nodes.end(),
----------------
Comments?


================
Comment at: tools/llvm-mca/Views/BottleneckAnalysis.h:139
 
-  // Pair of vertices connected by this edge.
+  // Pair of vertices which defines this edge.
   unsigned FromIID;
----------------
A lot of this is independent of the patch - precommit cleanup?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63543/new/

https://reviews.llvm.org/D63543