[PATCH] D63239: [llvm-objcopy][NFC] Refactor output target parsing

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 19 04:26:04 PDT 2019


jhenderson accepted this revision.
jhenderson added a comment.

LGTM, with one comment fix.



================
Comment at: llvm/tools/llvm-objcopy/CopyConfig.cpp:471
+
+  // FIXME:  Currently, We ignore the target for non-binary/ihex formats
+  // explicitly specified by -I option (e.g. -Ielf32-x86-64) and guess the
----------------
Nit: We -> we


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63239/new/

https://reviews.llvm.org/D63239





More information about the llvm-commits mailing list