[PATCH] D63494: [AMDGPU] Fix for branch offset hardware workaround

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 18 16:32:09 PDT 2019


arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/MCTargetDesc/AMDGPUAsmBackend.cpp:64
+  case AMDGPU::S_CBRANCH_SCC0:
+    return AMDGPU::S_CBRANCH_SCC0_64;
+  case AMDGPU::S_CBRANCH_SCC1:
----------------
These names aren't good. I would prefer a sufficient like _pad_s_nop or something. 64 could mean many different things


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63494/new/

https://reviews.llvm.org/D63494





More information about the llvm-commits mailing list