[PATCH] D63496: [WIP] CodeGen: Prototype class for registers

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 18 12:18:03 PDT 2019


arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: include/llvm/CodeGen/Register.h:27
+    //assert(!isStackSlot(Reg) && "Not a register! Check isStackSlot() first.");
+    return int(Reg) > 0;
+  }
----------------
arsenm wrote:
> qcolombet wrote:
> > I am not sure I like those, since it still allows using Reg as plain unsigned.
> I missed the parameter types here. Do you think trying to preserve the isStackSlot is important?
I guess this can be made private


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63496/new/

https://reviews.llvm.org/D63496





More information about the llvm-commits mailing list