[PATCH] D43515: More math intrinsics for conservative math handling

Andy Kaylor via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 18 12:49:57 PDT 2019


andrew.w.kaylor added a comment.

In D43515#1548845 <https://reviews.llvm.org/D43515#1548845>, @kpn wrote:

> I believe the speculative exceptions should be largely fixed by r348251, committed by rksimon. I changed the code to continue to use strict nodes when expanding a strict node. Since the strict nodes are chained, does that not solve the part of the problem not solved by r348251? Is the existing comment not enough, or do I need to copy some of the commit message into code comments?


Sorry, I wasn't aware of Simon's change.  That definitely simplifies what needs to be done here, and, yes, the existing comment is sufficient.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D43515/new/

https://reviews.llvm.org/D43515





More information about the llvm-commits mailing list