[PATCH] D63500: [FileCheck] Stop qualifying expressions as numeric

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

I think this is a definite improvement in readability, once you fix the two places that seem to have lost a line of commentary.



================
Comment at: llvm/docs/CommandGuide/FileCheck.rst:599
+  the operation <op>. It must be present if ``<op>`` is present, absent
+  otherwise.
 
----------------
Some sort of mis-edit here.


================
Comment at: llvm/include/llvm/Support/FileCheck.h:472
                                               const SourceMgr &SM);
-  /// Parses \p Expr for a numeric substitution block. \returns the class
-  /// representing the AST of the numeric expression whose value must be
-  /// substituted, or an error holding a diagnostic against \p SM if parsing
-  /// fails. If substitution was successful, sets \p DefinedNumericVariable to
-  /// point to the class representing the numeric variable defined in this
-  /// numeric substitution block, or None if this block does not define any
-  /// variable.
-  Expected<FileCheckNumExpr *> parseNumericSubstitutionBlock(
+  /// representing the AST of the expression whose value must be substituted,
+  /// or an error holding a diagnostic against \p SM if parsing fails. If
----------------
Looks like a line was lost by accident?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63500/new/

https://reviews.llvm.org/D63500