[PATCH] D63499: Add debug location verification for !llvm.loop attachments

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando accepted this revision.
Orlando added a comment.
This revision is now accepted and ready to land.

LGTM. Thanks for doing this!



================
Comment at: llvm/lib/IR/Verifier.cpp:2380
+        for (unsigned i = 1; i < MD->getNumOperands(); ++i)
+          VisitDebugLoc(I, dyn_cast_or_null<MDNode>(MD->getOperand(i)));
+      if (BrokenDebugInfo)
----------------
The loop metadata can contain nodes which are not DILocations but the check at the start of VisitDebugLoc() will catch this, so this seems fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63499/new/

https://reviews.llvm.org/D63499