[PATCH] D62635: Add enums as global variables in the IR metadata.

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 18 10:04:38 PDT 2019


rnk added a comment.

In D62635#1548648 <https://reviews.llvm.org/D62635#1548648>, @dblaikie wrote:

> In D62635#1548157 <https://reviews.llvm.org/D62635#1548157>, @rnk wrote:
>
> > We did things this way to track which **enumerators** were used, not which enums were used. Size data showed it was worth doing (6%). The existing format doesn't support tracking usage of individual enumerators, so we pretended they were const integers to avoid changing the schema.
>
>
> Ah - describing all the enumerators in any emitted enum would be too many bits/too much size in output?


Yes, that's what @akhuang tried and measured against to come up with the 6% number.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62635/new/

https://reviews.llvm.org/D62635





More information about the llvm-commits mailing list