[PATCH] D62685: [RISCV] Add pseudo instruction for calls with explicit register

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 18 09:35:25 PDT 2019


asb accepted this revision.
asb added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: Jim.

This looks good to me if you make the following minor changes:

- add a test for `call a0, foo at plt`
- add negative tests to function-call-invalid.s as well e.g. `call foo, bar` etc.

Thanks!


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62685/new/

https://reviews.llvm.org/D62685





More information about the llvm-commits mailing list