[PATCH] D63344: lld/elf: Deduplicate undefined symbol diagnostics

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

In D63344#1548106 <https://reviews.llvm.org/D63344#1548106>, @thakis wrote:

> > How long is the increase?
>
> That's a good question. Intuitively I'd say it shouldn't be all that much: Undefined diags were emitted doing relocation scanning, which I think happens fairly late in the link, and now it happens after it. So the max latency added is the time it takes to scan relocations. I'd expect that relocation scanning time is small compared to total link time. But I'll measure and report back.


Thanks. I have a feeling that the relocation scan pass is one of the heaviest pass in lld, so it's worth measuring.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63344/new/

https://reviews.llvm.org/D63344