[PATCH] D63455: [AMDGPU] Propagate function attributes thru bitcasts

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec created this revision.
rampitec added reviewers: kzhuravl, msearles.
Herald added subscribers: t-tye, tpr, dstuttard, yaxunl, nhaehnle, wdng, jvesely, arsenm.

AMDGPUPropagateAttributes will not work on function bitcatsts,
so move AMDGPUFixFunctionBitcasts before it.


https://reviews.llvm.org/D63455

Files:
  lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
  test/CodeGen/AMDGPU/propagate-attributes-bitcast-function.ll


Index: test/CodeGen/AMDGPU/propagate-attributes-bitcast-function.ll
===================================================================
--- /dev/null
+++ test/CodeGen/AMDGPU/propagate-attributes-bitcast-function.ll
@@ -0,0 +1,23 @@
+; RUN: llc -march=amdgcn -mcpu=gfx1010 -verify-machineinstrs < %s | FileCheck -check-prefix=GCN %s
+
+; GCN: foo1:
+; v_cndmask_b32_e64 v0, 0, 1, vcc_lo{{$}}
+; GCN: kernel1:
+; GCN: foo1 at gotpcrel32@lo+4
+; GCN: foo1 at gotpcrel32@hi+4
+
+define void @foo1(i32 %x) #1 {
+entry:
+  %cc = icmp eq i32 %x, 0
+  store volatile i1 %cc, i1* undef
+  ret void
+}
+
+define amdgpu_kernel void @kernel1(float %x) #0 {
+entry:
+  call void bitcast (void (i32)* @foo1 to void (float)*)(float %x)
+  ret void
+}
+
+attributes #0 = { nounwind "target-features"="+wavefrontsize32" }
+attributes #1 = { noinline nounwind "target-features"="+wavefrontsize64" }
Index: lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
===================================================================
--- lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
+++ lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
@@ -658,14 +658,15 @@
   disablePass(&FuncletLayoutID);
   disablePass(&PatchableFunctionID);
 
+  // This must occur before inlining, as the inliner will not look through
+  // bitcast calls.
+  addPass(createAMDGPUFixFunctionBitcastsPass());
+
   // A call to propagate attributes pass in the backend in case opt was not run.
   addPass(createAMDGPUPropagateAttributesEarlyPass(&TM));
 
   addPass(createAtomicExpandPass());
 
-  // This must occur before inlining, as the inliner will not look through
-  // bitcast calls.
-  addPass(createAMDGPUFixFunctionBitcastsPass());
 
   addPass(createAMDGPULowerIntrinsicsPass());
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63455.205167.patch
Type: text/x-patch
Size: 1712 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190617/88c8920e/attachment-0001.bin>