[PATCH] D63205: Virtualize TargetInstrInfo::getRegClass()

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added a comment.

In D63205#1546727 <https://reviews.llvm.org/D63205#1546727>, @bogner wrote:

> Maybe I'm missing something, but the override implemented in D63204 <https://reviews.llvm.org/D63204> looks like a subset of the default `TII::getRegClass` that falls through to `TRI::getRegClass`, just like the default does. Is this change actually necessary?


It will fallback to TRI::getRegClass(), but to the base class of it through the pointer to TRI in the InstrEmitter, so call goes to the default implementation. Either TII::getRegClass() needs to be virtual or TRI::getRegClass().
I have preferred to override in TII because it is called less frequently than from TRI.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63205/new/

https://reviews.llvm.org/D63205