[PATCH] D62964: [llvm-objdump] Match GNU objdump on symbol types shown in disassembly output.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Aside from one test comment, this looks good to me.



================
Comment at: llvm/test/tools/llvm-objdump/X86/elf-disassemble-dynamic-symbols.test:91
     Binding: STB_GLOBAL
-  ## The rest of the dynamic symbols won't be used for various reasons.
-  ## FIXME: the first two symbols here should be dumped.
-  ##        See https://bugs.llvm.org/show_bug.cgi?id=41947
-  - Name:    not_func
+  - Name:    both_func_dyn
     Value:   0x1003
----------------
I'm not sure I follow what the purpose of this particular symbol is beyond what `func_dyn` gives us?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62964/new/

https://reviews.llvm.org/D62964