[PATCH] D60389: FileCheck [9/12]: Add support for matching formats

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: llvm/unittests/Support/FileCheckTest.cpp:399
   // right value, getUndefVarNames does not return any variable.
+  auto DefNumExpr = FileCheckNumExpr(nullptr, FmtUnsigned);
   auto LineVar =
----------------
thopre wrote:
> grimar wrote:
> > There is a good practive to avoid using `auto` in case the type isn't obvious.
> But isn't it obvious in this case since we see the constructor call?
May be. I think I didn't realize it is a constructor call and not a helper function call when saw this.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60389/new/

https://reviews.llvm.org/D60389