[PATCH] D63393: [llvm-objdump] Remove unnecessary indentation when dumping ELF data.

[Yuanfang Chen via Phabricator via llvm-commits]

ychen updated this revision to Diff 205227.
ychen marked 4 inline comments as done.
ychen added a comment.

- update test


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63393/new/

https://reviews.llvm.org/D63393

Files:
  llvm/test/tools/llvm-objdump/X86/disassemble-code-data-mix.s
  llvm/tools/llvm-objdump/llvm-objdump.cpp


Index: llvm/tools/llvm-objdump/llvm-objdump.cpp
===================================================================
--- llvm/tools/llvm-objdump/llvm-objdump.cpp
+++ llvm/tools/llvm-objdump/llvm-objdump.cpp
@@ -995,10 +995,8 @@
   int NumBytes = 0;
 
   for (; Index < End; ++Index) {
-    if (NumBytes == 0) {
+    if (NumBytes == 0)
       outs() << format("%8" PRIx64 ":", SectionAddr + Index);
-      outs() << "\t";
-    }
     Byte = Bytes.slice(Index)[0];
     outs() << format(" %02x", Byte);
     AsciiData[NumBytes] = isPrint(Byte) ? Byte : '.';
Index: llvm/test/tools/llvm-objdump/X86/disassemble-code-data-mix.s
===================================================================
--- llvm/test/tools/llvm-objdump/X86/disassemble-code-data-mix.s
+++ llvm/test/tools/llvm-objdump/X86/disassemble-code-data-mix.s
@@ -1,4 +1,4 @@
-// RUN: llvm-mc %s -filetype=obj -triple=x86_64-pc-linux | llvm-objdump -d - | FileCheck %s
+// RUN: llvm-mc %s -filetype=obj -triple=x86_64-pc-linux | llvm-objdump -d - | tr '\t' '|' | FileCheck --strict-whitespace --match-full-lines %s
         .text
         .globl  foo
         .type   foo, @function
@@ -14,6 +14,5 @@
 bar:
         .string "test string"
 
-// CHECK:        b:        74 65 73 74 20 73 74 72         test str
-// CHECK-NEXT:  13:        69 6e 67 00                     ing.
-
+// CHECK:       b: 74 65 73 74 20 73 74 72         test str
+// CHECK-NEXT:      13: 69 6e 67 00                     ing.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63393.205227.patch
Type: text/x-patch
Size: 1460 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190618/14e9a7b8/attachment.bin>