[PATCH] D63102: Fix some lit test ResourceWarnings on Windows

[Adrian McCarthy via Phabricator via llvm-commits]

amccarth marked an inline comment as done.
amccarth added inline comments.


================
Comment at: llvm/utils/lit/lit/TestRunner.py:772
         if cmd.op == ';':
-            res = _executeShCmd(cmd.lhs, shenv, results, timeoutHelper)
+            _executeShCmd(cmd.lhs, shenv, results, timeoutHelper)
             return _executeShCmd(cmd.rhs, shenv, results, timeoutHelper)
----------------
delcypher wrote:
> What does this change have to do with closing files?
That was a leftover change from the diagnosis phase.  The resource leak was always reported on the following line (773), so a lot of the attention was focused in this region even though the actual fix was below.

I was just trying to leave the code a little cleaner than I found it by eliminating the unused variable.  But, you're right, it's not relevant to the point of this patch, so I'll undo it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63102/new/

https://reviews.llvm.org/D63102