[PATCH] D63280: [llvm-objdump] Use <first-symbol>-<offset> as the section start symbol

[Yuanfang Chen via Phabricator via llvm-commits]

ychen marked 4 inline comments as done.
ychen added inline comments.


================
Comment at: llvm/test/MC/AMDGPU/branch-comment.s:13
 s_branch loop_end_nosym
-// BIN: s_branch 0 // 000000000004: BF820000 <.text+0x8>
+// BIN: s_branch 0 // 000000000004: BF820000 <keep_symbol-0xC+0x8>
 // BIN-NOT: loop_end_nosym:
----------------
jhenderson wrote:
> This one is particularly concerning. Does this case match GNU? I'd expect it to fold the two sums together (i.e. `keep_symbol-0x4`)
Thanks for pointing this out. GNU objdump does not use the dummy start symbol for branch target resolving (folding). Code updated. Added a test case for this `llvm/test/MC/X86/branch-comment.s`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63280/new/

https://reviews.llvm.org/D63280