[PATCH] D63452: AMDGPU: Support some GDS atomics

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: test/CodeGen/AMDGPU/gds-atomic.ll:25
+}
+
+declare i32 @llvm.amdgcn.ds.ordered.add(i32 addrspace(2)* nocapture, i32, i32, i32, i1, i32, i32, i1, i1)
----------------
Seems to be missing at least cmpxchg? Is this intended to handle all of the memory ops at once?


================
Comment at: test/CodeGen/AMDGPU/gds-atomic.ll:26
+
+declare i32 @llvm.amdgcn.ds.ordered.add(i32 addrspace(2)* nocapture, i32, i32, i32, i1, i32, i32, i1, i1)
+
----------------
Dead declaration


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63452/new/

https://reviews.llvm.org/D63452