[PATCH] D63450: Stop counting pops in tsan/check_analyze.sh.

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 17 11:27:40 PDT 2019


eugenis created this revision.
eugenis added reviewers: vitalybuka, dvyukov.
Herald added subscribers: Sanitizers, kubamracek.
Herald added projects: Sanitizers, LLVM.

It looks like LLVM has started doing less tail duplication in this code,
or something like that, resulting in a significantly smaller number of
pop instructions (16 -> 12). Removing the check.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D63450

Files:
  compiler-rt/lib/tsan/check_analyze.sh


Index: compiler-rt/lib/tsan/check_analyze.sh
===================================================================
--- compiler-rt/lib/tsan/check_analyze.sh
+++ compiler-rt/lib/tsan/check_analyze.sh
@@ -37,13 +37,13 @@
 for f in write1 write2 write4 write8; do
   check $f rsp 1
   check $f push 2
-  check $f pop 16
+#  check $f pop 16
 done
 
 for f in read1 read2 read4 read8; do
   check $f rsp 1
   check $f push 3
-  check $f pop 24
+#  check $f pop 24
 done
 
 for f in func_entry func_exit; do


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63450.205132.patch
Type: text/x-patch
Size: 500 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190617/9a427195/attachment.bin>


More information about the llvm-commits mailing list