[PATCH] D63449: [GN] Generation failure caused by trailing space in file name

[Min-Yih Hsu via Phabricator via llvm-commits]

myhsu created this revision.
myhsu added a reviewer: phosek.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Hi,

When I executed `gn.py gen out/gn` I got the following error:

  ERROR at //compiler-rt/lib/builtins/BUILD.gn:162:7: Only source, header, and object files belong in the sources of a static_library. //compiler-rt/lib/builtins/emutls.c  is not one of the valid types.
        "emutls.c ",
        ^----------
  See //compiler-rt/lib/BUILD.gn:3:5: which caused the file to be included.
      "//compiler-rt/lib/builtins",
      ^---------------------------

It turns out to be that the latest gn doesn't accept ill-format file name <https://gn.googlesource.com/gn/+/8730b0feb6b991fa47368566501ab9ccfb453c92>. And the `emutls.c` above has a trailing space.
Remove the trailing space should work.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D63449

Files:
  llvm/utils/gn/secondary/compiler-rt/lib/builtins/BUILD.gn


Index: llvm/utils/gn/secondary/compiler-rt/lib/builtins/BUILD.gn
===================================================================
--- llvm/utils/gn/secondary/compiler-rt/lib/builtins/BUILD.gn
+++ llvm/utils/gn/secondary/compiler-rt/lib/builtins/BUILD.gn
@@ -159,7 +159,7 @@
 
   if (target_os != "fuchsia") {
     sources += [
-      "emutls.c ",
+      "emutls.c",
       "enable_execute_stack.c",
       "eprintf.c",
     ]


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63449.205122.patch
Type: text/x-patch
Size: 429 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190617/3d207f54/attachment.bin>