[PATCH] D63389: [IDF] Generalize IDFCalculator to be used with Clang's CFG

Kristóf Umann via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 17 10:21:43 PDT 2019


Szelethus added a comment.

In D63389#1546470 <https://reviews.llvm.org/D63389#1546470>, @asbirlea wrote:

> We do very much need GraphDiff in the IDFCalculator when doing updates in MemorySSA. I don't know how I missed this, since it was the very reason it was added, but thanks a lot for catching it.
>  I'll send a patch with the fix shortly.


Glad its back! How does yet another class (`IDFGraphDiffCalculator`) sound like? With that, I could use template specializations instead of virtual functions.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63389/new/

https://reviews.llvm.org/D63389





More information about the llvm-commits mailing list