[PATCH] D62105: [CommandLine] Remove OptionCategory and SubCommand caches from the Option class.

[Don Hinton via Phabricator via llvm-commits]

hintonda marked an inline comment as done.
hintonda added inline comments.


================
Comment at: llvm/include/llvm/Support/CommandLine.h:1797
+  // Fixes CommandLineTest.AliaswithSubCommand.
+  void addArgument(SubCommand &SC) {}
+
----------------
serge-sans-paille wrote:
> hintonda wrote:
> > Will fix this and related methods by making them virtual and adding asserts saying the operation isn't allowed/doesn't make sense in a separate patch.
> Why do you want to do that in a separate patch?
Sorry, that comment is OBE.  I made it virtual instead.

My original reasoning was to make each patch smaller, but found breaking it up further un-workable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62105/new/

https://reviews.llvm.org/D62105