[PATCH] D62838: [Object] add isExecutableObject member function

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

Couple of minor nits, but otherwise LGTM.



================
Comment at: llvm/unittests/Object/ObjectFileTest.cpp:77
+template <typename header_t>
+void createObjectFile(std::unique_ptr<ObjectFile> &ObjPtr, header_t &Header,
+                      file_magic Magic = file_magic::unknown) {
----------------
Can Header be a `const &`? Also, I think header_t should follow standard LLVM type naming (i.e. UpperCamelCase, e.g. HeaderType).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62838/new/

https://reviews.llvm.org/D62838