[PATCH] D63394: [yaml2obj][ELF] Suport STT_LOOS, STT_HIOS, STT_LOPROC and STT_HIPROC.

Yuanfang Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 17 08:47:23 PDT 2019


ychen added a comment.

In D63394#1545670 <https://reviews.llvm.org/D63394#1545670>, @jhenderson wrote:

> Sorry, I don't think this should be done, as these values are just range delimiters, not actually values that a symbol's type can be. If a symbol in that range is required, it should either be specified by the actual value required (e.g. just "11") or with a corresponding specific enumeration value, if available (e.g. STT_MYOS_TYPE).


I'm totally fine with not commit this. But it seems just a small convenience from a tooling perspective (no need for the semantics of the symbol type) when you need the value but not in an OS or processor specific way and STT_LOOS looks better than "10"?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63394/new/

https://reviews.llvm.org/D63394





More information about the llvm-commits mailing list