[PATCH] D60831: [DebugInfo at O2][LoopVectorize] pr39024: Vectorized code linenos step through loop even after completion

Orlando Cazalet-Hyams via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 17 02:36:49 PDT 2019


Orlando added a comment.

Hi Adrian.

This seems to be a case of having old, incorrect, metadata baked into the test.
The 'startLoc' (!680) and 'endLoc' (!681) in loop metadta for loop !679 are both
missing an 'inlinedAt' node.

  !680 = !DILocation(line: 258, column: 5, scope: !659)
  !681 = !DILocation(line: 259, column: 30, scope: !659)

Regenerating this test with patch rG1a0f7a2077b7 <https://reviews.llvm.org/rG1a0f7a2077b70c9864faa476e15b048686cf1ca7> should fix this.

Note: clang reports no errors when the follwoing DILocations are modified by 
hand. !660 is a DILocation with scope !647 which refers to a location within
the caller.

  !680 = !DILocation(line: 258, column: 5, scope: !659, inlinedAt: !660)
  !681 = !DILocation(line: 259, column: 30, scope: !659, inlinedAt: !660)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60831/new/

https://reviews.llvm.org/D60831





More information about the llvm-commits mailing list