[PATCH] D63383: [ELF][ARM][AARCH64][MIPS][PPC] Simplify the logic to create R_*_RELATIVE for absolute relocation types in writable sections

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 17 06:28:36 PDT 2019


peter.smith added a comment.

>From the Arm and AArch64 side this looks good to me, probably best if the Mips and PPC experts confirm their parts.



================
Comment at: test/ELF/arm-abs32-dyn.s:17
 
+// In PIC mode, if R_ARM_TARGET1 represents R_ARM_32 (the default), an
+// R_ARM_TARGET1 to a non-preemptable symbol also creates an R_ARM_RELATIVE in
----------------
R_ARM_32 should be R_ARM_ABS32.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63383/new/

https://reviews.llvm.org/D63383





More information about the llvm-commits mailing list