[PATCH] D63344: lld/elf: Deduplicate undefined symbol diagnostics

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

I think that the three patches make sense only when they are combined, so could you merge them as a single patch?



================
Comment at: lld/Common/ErrorHandler.cpp:137
 
-  ++ErrorCount;
+  ErrorCount += NDiags;
 }
----------------
To me, reporting a single undefined symbol that is used by multiple object files is still counted as a single error. That kind of error is actually likely to be caused by a single error to forget defining a symbol or something.

I don't feel strongly about that, though. But in that case, I'd choose a simpler one. Handle all error() calls as a single erorr is simpler.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63344/new/

https://reviews.llvm.org/D63344