[PATCH] D63321: [SVE][IR] Scalable Vector IR Type with pr42210 fix

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 17 04:07:22 PDT 2019


sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.

Removing the recursion solves the compile-time issue and still catches all invalid cases.
LGTM.



================
Comment at: test/Verifier/scalable-aggregates.ll:7
+
+; CHECK-DAG: Arrays cannot contain scalable vectors
+; CHECK-DAG:  [4 x <vscale x 256 x i1>]; ModuleID = '<stdin>'
----------------
Just pointing out that the Verifier still errors on all the same invalid cases, but now only the reports errors once compared to the previous patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63321/new/

https://reviews.llvm.org/D63321





More information about the llvm-commits mailing list