[PATCH] D63393: [llvm-objdump] Remove unnecessary indentation when dumping ELF data.
Yuanfang Chen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Jun 16 19:35:59 PDT 2019
ychen updated this revision to Diff 204988.
ychen added a comment.
- add test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63393/new/
https://reviews.llvm.org/D63393
Files:
llvm/test/tools/llvm-objdump/X86/disassemble-code-data-mix.s
llvm/tools/llvm-objdump/llvm-objdump.cpp
Index: llvm/tools/llvm-objdump/llvm-objdump.cpp
===================================================================
--- llvm/tools/llvm-objdump/llvm-objdump.cpp
+++ llvm/tools/llvm-objdump/llvm-objdump.cpp
@@ -996,10 +996,8 @@
int NumBytes = 0;
for (; Index < End; ++Index) {
- if (NumBytes == 0) {
+ if (NumBytes == 0)
outs() << format("%8" PRIx64 ":", SectionAddr + Index);
- outs() << "\t";
- }
Byte = Bytes.slice(Index)[0];
outs() << format(" %02x", Byte);
AsciiData[NumBytes] = isPrint(Byte) ? Byte : '.';
Index: llvm/test/tools/llvm-objdump/X86/disassemble-code-data-mix.s
===================================================================
--- llvm/test/tools/llvm-objdump/X86/disassemble-code-data-mix.s
+++ llvm/test/tools/llvm-objdump/X86/disassemble-code-data-mix.s
@@ -1,4 +1,4 @@
-// RUN: llvm-mc %s -filetype=obj -triple=x86_64-pc-linux | llvm-objdump -d - | FileCheck %s
+// RUN: llvm-mc %s -filetype=obj -triple=x86_64-pc-linux | llvm-objdump -d - | tr '\t' '|' | FileCheck %s
.text
.globl foo
.type foo, @function
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63393.204988.patch
Type: text/x-patch
Size: 1105 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190617/f8938296/attachment.bin>
More information about the llvm-commits
mailing list