[PATCH] D61494: AMDGPU: Write LDS objects out as global symbols in code generation

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 16 18:06:52 PDT 2019


nhaehnle updated this revision to Diff 204982.
nhaehnle marked 3 inline comments as done.
nhaehnle added a comment.

Wrap LDS TargetGlobalAddress nodes in an AMDGPUISD::LDS node that is
selected to S_MOV/V_MOV. This should address the concerns about having
more machine nodes during SelectionDAG, and as a nice side bonus it
actually improves the quality of known-bits information by adding
alignment information as well.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61494/new/

https://reviews.llvm.org/D61494

Files:
  lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp
  lib/Target/AMDGPU/AMDGPUISelLowering.cpp
  lib/Target/AMDGPU/AMDGPUISelLowering.h
  lib/Target/AMDGPU/SIFoldOperands.cpp
  lib/Target/AMDGPU/SIISelLowering.cpp
  lib/Target/AMDGPU/SIInstrInfo.cpp
  lib/Target/AMDGPU/SIInstrInfo.td
  lib/Target/AMDGPU/SIInstructions.td
  lib/Target/AMDGPU/SIShrinkInstructions.cpp
  test/CodeGen/AMDGPU/32-bit-local-address-space.ll
  test/CodeGen/AMDGPU/ds-sub-offset.ll
  test/CodeGen/AMDGPU/ds_read2.ll
  test/CodeGen/AMDGPU/ds_write2.ll
  test/CodeGen/AMDGPU/lds-initializer.ll
  test/CodeGen/AMDGPU/lds-relocs.ll
  test/CodeGen/AMDGPU/lds-size.ll
  test/CodeGen/AMDGPU/lds-zero-initializer.ll
  test/CodeGen/AMDGPU/llvm.amdgcn.atomic.dec.ll
  test/CodeGen/AMDGPU/llvm.amdgcn.atomic.inc.ll
  test/CodeGen/AMDGPU/llvm.amdgcn.groupstaticsize.ll
  test/CodeGen/AMDGPU/local-memory.amdgcn.ll
  test/CodeGen/AMDGPU/local-memory.ll
  test/CodeGen/AMDGPU/merge-store-crash.ll
  test/CodeGen/AMDGPU/over-max-lds-size.ll
  test/CodeGen/AMDGPU/promote-alloca-globals.ll
  test/CodeGen/AMDGPU/shl_add_ptr.ll
  test/CodeGen/AMDGPU/si-sgpr-spill.ll
  test/CodeGen/AMDGPU/target-cpu.ll
  test/CodeGen/MIR/AMDGPU/machine-function-info.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61494.204982.patch
Type: text/x-patch
Size: 42346 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190617/52916929/attachment.bin>


More information about the llvm-commits mailing list