[PATCH] D63109: lld-link: Reject more than one resource .obj file

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In D63109#1545204 <https://reviews.llvm.org/D63109#1545204>, @mstorsjo wrote:

> FWIW, I ran into one error with this on VLC. In one case, a static library ends up (erroneously) containing a resource object file. This static library is included with the `--whole-archive` option (indirectly, via lots of libtool magic) when linking a DLL, which also contains a resource object files of its own.
>
> In that case, it's possible to fix the issue by removing the intermediate static library which seems to be pointless at the moment. But extending lld to ignore resource object files when linking with `--whole-archive` would probably be good.


Actually, the intermediate static library does seem to be there for a reason (the reason being automake and libtool details), so the solution is either to fight more automake weirdness to try to avoid adding the resource object file to it, or make lld ignore such objects when used with `--whole-archive`.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63109/new/

https://reviews.llvm.org/D63109