[PATCH] D61492: AMDGPU: Prepare for explicit absolute relocations in code generation

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 16 10:42:47 PDT 2019


nhaehnle marked 2 inline comments as done.
nhaehnle added inline comments.


================
Comment at: lib/Target/AMDGPU/MCTargetDesc/SIMCCodeEmitter.cpp:405-408
+    if (Kind == MCSymbolRefExpr::VK_AMDGPU_ABS32_LO ||
+        Kind == MCSymbolRefExpr::VK_AMDGPU_ABS32_HI)
+      return false;
     return true;
----------------
arsenm wrote:
> return Kind != lo && Kind != Hi
Yeah, that makes sense. Thanks!


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61492/new/

https://reviews.llvm.org/D61492





More information about the llvm-commits mailing list