[PATCH] D62838: [Object] add isExecutableObject member function

Jordan Rupprecht via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 14 11:45:14 PDT 2019


rupprecht added inline comments.


================
Comment at: llvm/unittests/Object/ObjectFileTest.cpp:80
+// gtest macros return something.
+#define createObjFile(Ptr, Header, Magic)                                      \
+  StringRef Bytes(reinterpret_cast<const char *>(&Header), sizeof(Header));    \
----------------
Why a macro? Can you create a templated method instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62838/new/

https://reviews.llvm.org/D62838





More information about the llvm-commits mailing list