[PATCH] D63337: [AMDGPU] Don't constrain callees with inlinehint from inlining on MaxBB check to prevent link failure

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 14 09:06:35 PDT 2019


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUInline.cpp:221-222
 
-  if (IC && !IC.isAlways()) {
+  // Don't constrain callees with inlinehint as it may result in link failure
+  if (IC && !IC.isAlways() && !Callee->hasFnAttribute(Attribute::InlineHint)) {
     // Single BB does not increase total BB amount, thus subtract 1
----------------
inlinehint shouldn't be impacting correctness


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63337/new/

https://reviews.llvm.org/D63337





More information about the llvm-commits mailing list