[PATCH] D63191: [lld][ELF] Check length of subsection in .ARM.attributes

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 14 06:23:52 PDT 2019


peter.smith added a comment.

In D63191#1543468 <https://reviews.llvm.org/D63191#1543468>, @evgeny777 wrote:

> > would be to drop the size field to 0xFE, 0xFF, 0xFF, 0xFF.
>
> This would cause problems on arm-be, no?


That would give a different (smaller I think) size on BE yes, although LLD doesn't support big-endian at the moment. I kind of picked the first  value that came into my head anyway, so by all means pick something else if you want to change the test.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63191/new/

https://reviews.llvm.org/D63191





More information about the llvm-commits mailing list