[PATCH] D63249: [LLD] [MinGW] Support the --{major,minor}-{os,subsystem}-version options

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 14 06:23:28 PDT 2019


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: MinGW/Driver.cpp:205
+    Add("-subsystem:" + SubSys + "," + Major + Sep + Minor);
+  } else if (auto *A = Args.getLastArg(OPT_subs))
     Add("-subsystem:" + StringRef(A->getValue()));
----------------
nit: add {} after `else if` if `if` has {}.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63249/new/

https://reviews.llvm.org/D63249





More information about the llvm-commits mailing list