[PATCH] D63239: [llvm-objcopy] Refactor output target parsing

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 14 03:17:26 PDT 2019


jhenderson added a comment.

LGTM, with one nit. Also, if I understand it correctly, this change should have no functional change, right? In that case, please tag the summary with [NFC] (i.e. [llvm-objcopy][NFC] Refactor output target parsing) when you commit.



================
Comment at: llvm/tools/llvm-objcopy/CopyConfig.cpp:324
                              OriginalFormat.str().c_str());
-  MachineInfo MI = Iter->getValue();
+  auto Target = Iter->getValue();
   if (IsFreeBSD)
----------------
I don't think you need to use `auto` here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63239/new/

https://reviews.llvm.org/D63239





More information about the llvm-commits mailing list