[PATCH] D63313: [llvm-objcopy] Remove no-op flush of errs

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 14 01:06:03 PDT 2019


lebedev.ri added a comment.

In D63313#1543002 <https://reviews.llvm.org/D63313#1543002>, @abrachet wrote:

> https://github.com/llvm/llvm-project/blob/master/llvm/lib/Support/raw_ostream.cpp#L854 shows that errs is unbuferred.


That's actually kind-of a problem. Unless *something* ensures that all the output
that was written into that is flushed, it may end up being dropped, rL360124 <https://reviews.llvm.org/rL360124>.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63313/new/

https://reviews.llvm.org/D63313





More information about the llvm-commits mailing list