[PATCH] D63162: GlobalISel: Avoid producing Illegal copies in RegBankSelect

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 13 11:43:34 PDT 2019


arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: lib/CodeGen/GlobalISel/RegisterBankInfo.cpp:252
     return getInvalidInstructionMapping();
+  }
 
----------------
qcolombet wrote:
> From LLVM standard: no brackets here.
I will die on the hill that there should be braces here. There are multiple lines after the if due to the comment. I don't see where it says this, and clang-format doesn't touch it


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63162/new/

https://reviews.llvm.org/D63162





More information about the llvm-commits mailing list