[PATCH] D62990: [SCEV]When safe, use Stride as MinStart in computeMaxBECountForLT

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 13 11:26:29 PDT 2019


efriedma added a comment.

Is the isLoopEntryGuardedByCond actually proving what you need it to prove?  Even if `Start-Stride` is in the range `[0, End)`, that doesn't necessarily imply `Start-Stride` doesn't overflow. For example, suppose Start is 0, End is -1, and Stride is 2.

I guess if we prove both Stride and End are nonnegative, it's okay.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62990/new/

https://reviews.llvm.org/D62990





More information about the llvm-commits mailing list