[PATCH] D63258: [llvm-objcopy][IHEX] Improve test case formatting. NFC

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: test/tools/llvm-objcopy/ELF/ihex-reader.test:149
+## Check for various parsing errors.
+# 1. String too short
+# RUN: echo "01000000FF" | not llvm-objcopy -I ihex -O elf32-i386  - - 2>&1 | FileCheck %s --check-prefix=BAD_LENGTH
----------------
Missed a '##' here.


================
Comment at: test/tools/llvm-objcopy/ELF/ihex-reader.test:207
+
+## 13. no sections in the hex file.
+# a) try empty file:
----------------
Nit: all of these should start with a capital letter.


================
Comment at: test/tools/llvm-objcopy/ELF/ihex-reader.test:210-211
+# RUN: echo "" | not llvm-objcopy -I ihex -O elf32-i386 - - 2>&1 | FileCheck %s --check-prefix=NO_SECTIONS
+# b) EOF record should cancel processing further records. Not having any section data
+#    before EOF should trigger an error
+# RUN: echo ":00000001FF" > %t-bad14.hex
----------------
'##' here too. Also missing a trailing full stop.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63258/new/

https://reviews.llvm.org/D63258