[PATCH] D63076: [ELF][RISCV] Support PLT, GOT, copy and relative relocations

[Fangrui Song via Phabricator via llvm-commits]

MaskRay marked 7 inline comments as done.
MaskRay added inline comments.


================
Comment at: ELF/Arch/RISCV.cpp:132
+void RISCV::writePltHeader(uint8_t *Buf) const {
+  if (Config->EFlags & EF_RISCV_RVE)
+    error("PLT is not supported for RVE");
----------------
ruiu wrote:
> Can you add a comment saying that RV32E/RV64E is fewer number of registers and PLTs are not supported on them because some registers that the PLT stub uses don't exist?
I just deleted this code.

I read from somewhere that RV32E may not support dynamic linking. If that is true, we can move the error checking to an appropriate place to check `!SharedFiles.empty() || Config->Shared` instead. rv32 hasn't been upstreamed to glibc yet. I think rv32e is not stable now.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63076/new/

https://reviews.llvm.org/D63076