[PATCH] D63238: [llvm-objcopy] Add elf32-sparc target

[Seiya Nuta via Phabricator via llvm-commits]

seiya marked an inline comment as done.
seiya added a comment.

In D63238#1541201 <https://reviews.llvm.org/D63238#1541201>, @jhenderson wrote:

> Looks good, I think, but does GNU objcopy have sparc as -I/-O type? Is the syntax the same as you have used?


Yes, it has the same target name. I'm not familiar with SPARC at all, but now I noticed that 32-bit SPARC is big endian and `gnu-objcopy -Oelf32-sparc` certainly emits a big endian ELF file. I think I should fix the SPARC entry in `ArchMap` before committing this patch. What do you think on this?



================
Comment at: llvm/tools/llvm-objcopy/CopyConfig.cpp:266
     {"riscv:rv64", {ELF::EM_RISCV, true, true}},
     {"sparc", {ELF::EM_SPARC, false, true}},
     {"x86-64", {ELF::EM_X86_64, true, true}},
----------------
I mean this 32-bit SPARC entry should be big endian.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63238/new/

https://reviews.llvm.org/D63238